Skip to content

Close dropdown when "Reload"-Entity Action has executed #19808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

madsrasmussen
Copy link
Contributor

Fixes #19761

Updated the event listener for 'action-executed' to bind the handler to the class instance, ensuring correct 'this' context when the event is triggered.
@Copilot Copilot AI review requested due to automatic review settings July 28, 2025 18:13
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an event handler binding issue where the 'action-executed' event listener was not properly bound to the class instance context. The change ensures that when the event handler is invoked, it maintains the correct this context.

  • Binds the #onActionExecuted method to the class instance when adding the event listener

@madsrasmussen madsrasmussen changed the title Bind 'action-executed' event handler to class instance Close dropdown when "Reload"-Entity Action has executed Jul 28, 2025
@nielslyngsoe nielslyngsoe enabled auto-merge (squash) July 28, 2025 18:52
@nielslyngsoe nielslyngsoe merged commit 13bb25a into main Aug 13, 2025
27 checks passed
@nielslyngsoe nielslyngsoe deleted the v16/bugfix/Reload-entity-action-does-not-close-entity-action-menu branch August 13, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

16.1.0-rc - Reload entity action does not close entity action menu
2 participants